feat(select): add isClearable to select component #4760

abhinav700 · 2025-01-29T14:42:30Z

this PR is duplicate of #3746
it adds a clear functionality to the select component.

* chore(changset): add changeset * fix(theme): apply nested group to table * chore(docs): update table bottomContent code

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: add support validationBehavior aria * chore: add validationBehavior to Provider * chore: add autocomplete validation test * chore: add checkbox validation test * fix(input): require condition * docs: add description of validationBehavior props * chore: add support validationBehavior props for date components * docs(dates): add description of validationBehavior props * chore: add changeset * chore: format * chore: fix test * fix: select validationBehavior is not support yet * fix: select validationBehavior not supported yet * feat: add form component with input support * feat: add support form context * chore: wip add support for form server errors * chore: add support checkbox server validation * chore: add support radio server validation * chore: update pnpm-lock.yaml * chore: add support input server validation * chore: add support autocomplete server validation * chore(form): add server validation stories * chore: fix test * chore: add date-picker validation test * chore: update form stories * chore: add changeset * chore: update react-aria version * chore: add pnpm-lock.yaml * chore: update react-aria version * chore: add comment * chore: update react-aria version * chore: fix change set * chore: export form component in the main package * chore: upgrade react-aria * chore: fixed internationalized/date version * fix: build error * chore: upgrade docs react-aria version * fix: remove comment * fix: debug setting * chore(docs): update sponsor (heroui-inc#3904) * chore(docs): remove Scrumbuiss * chore(docs): remove Scrumbuiss logo * chore(docs): replace va by posthog (heroui-inc#4123) * chore(changeset): change to patch * refactor: react-aria-components remove to decrease package size, logic moved to the form package --------- Co-authored-by: Junior Garcia <[email protected]> Co-authored-by: WK Wong <[email protected]>

Co-authored-by: Ryo Matsukawa <[email protected]>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(select): controlled isInvalid prop * chore: add changeset * Merge branch 'beta/release-next' into pr/4082 --------- Co-authored-by: WK Wong <[email protected]>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…c#4161)

…eroui-inc#4163)

* fix: menu item classNames not work * feat: changeset * docs: update * feat: merge classes utility added * Update .changeset/brave-trains-wave.md --------- Co-authored-by: WK Wong <[email protected]> Co-authored-by: Junior Garcia <[email protected]>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* refactor(docs): revise code block (heroui-inc#3922) * refactor(docs): revise code block * chore(docs): resolve pr comments * refactor(docs): autocomplete dx (heroui-inc#3934) * feat(docs): add *.js?raw module * feat(docs): change to react-jsx and add **/*.js * chore(root): include js and jsx * refactor(docs): autocomplete dx * chore(docs): rollback overrides * chore(autocomplete): lint * fix(autocomplete): incorrect import path * fix(docs): autocomplete dx * chore(docs): remove highlightedLines * refactor(docs): breadcrumbs dx (heroui-inc#3968) * refactor(docs): breadcrumbs dx * fix(docs): export issue * chore(docs): use preserve for jsx * fix(docs): support multiline import * fix(docs): support multiple export * chore(docs): add back export * refactor(docs): avatar dx (heroui-inc#3951) * refactor(docs): badge dx (heroui-inc#3960) * refactor(docs): badge dx * chore(docs): incorrect import path * refactor(docs): button dx (heroui-inc#3981) * refactor(docs): calendar dx (heroui-inc#4022) * refactor(docs): calendar dx * fix(docs): incorrect import path * refactor(docs): switch dx (heroui-inc#4037) * refactor(docs): switch dx * chore(docs): remove highlightedLines * refactor(docs): tooltip (heroui-inc#4035) * refactor(docs): usage dx (heroui-inc#4036) * refactor(docs): circular-progress dx (heroui-inc#4029) * refactor(docs): chip-dx (heroui-inc#4028) * refactor(docs): checkbox-group dx (heroui-inc#4027) * refactor(docs): checkbox dx (heroui-inc#4024) * refactor(docs): checkbox dx * fix(docs): incorrect import path * refactor(docs): card dx (heroui-inc#4023) * refactor(docs): skeleton dx (heroui-inc#4042) * refactor(docs): spacer dx (heroui-inc#4043) * refactor(docs): snippet dx (heroui-inc#4044) * refactor(docs): scroll-shadow dx (heroui-inc#4045) * refactor(docs): code dx (heroui-inc#4046) * refactor(docs): kbd dx (heroui-inc#4047) * refactor(docs): link dx (heroui-inc#4048) * refactor(docs): progress dx (heroui-inc#4049) * refactor(docs): divider dx (heroui-inc#4050) * refactor(docs): listbox dx (heroui-inc#4051) * refactor(docs): listbox dx * fix(docs): import path * fix(docs): import path * chore(docs): remove highlightedLines * fix(docs): indentation * chore(docs): replace the props of autocomplete from value to key (heroui-inc#4129) * refactor(docs): alert dx (heroui-inc#4108) * refactor(docs): alert dx * refactor(docs): alert dx * refactor(docs): image dx (heroui-inc#4061) * refactor(docs): textarea dx (heroui-inc#4063) * refactor(docs): spinner dx (heroui-inc#4088) * refactor(docs): radio-group dx (heroui-inc#4064) * refactor(docs): pagination dx (heroui-inc#4062) * refactor(docs): pagination dx * refactor(docs): pagination dx * refactor(docs): time-input dx (heroui-inc#4065) * refactor(docs): time-input dx * refactor(docs): time-input dx * refactor(docs): slider dx (heroui-inc#4066) * refactor(docs): slider dx * refactor(docs): slider dx * refactor(docs): move SliderValue to type * refactor(docs): slider dx * refactor(docs): make icon code collapsible * refactor(docs): specify versions for date packages (heroui-inc#4138) * refactor(docs): specify versions for date packages * fix(docs): correct RA i18n version * chore(deps): sync version from package * refactor(docs): tabs dx (heroui-inc#4067) * refactor(docs): tab dx * refactor(docs): tabs dx * refactor(docs): input dx (heroui-inc#4102) * refactor(docs): input dx * refactor(docs): input dx * refactor(docs): navbar dx (heroui-inc#4076) * refactor(docs): navbar dx * refactor(docs): navbar dx * refactor(docs): navbar dx * refactor(docs): modal dx (heroui-inc#4077) * refactor(docs): modal dx * refactor(docs): modal dx * refactor(docs): select dx (heroui-inc#4078) * refactor(docs): select dx * refactor(docs): select dx * refactor(docs): select dx * refactor(docs): select dx * refactor(docs): select dx * refactor(docs): table dx (heroui-inc#4079) * refactor(docs): table dx * fix(docs): import path * refactor(docs): table dx * refactor(docs): table dx * refactor(docs): popover dx (heroui-inc#4090) * refactor(docs): range-calendar dx (heroui-inc#4089) * refactor(docs): range-calendar dx * fix(docs): import path * refactor(docs): date input dx (heroui-inc#4100) * refactor(docs): dropdown dx (heroui-inc#4101) * refactor(docs): dropdown dx * refactor(docs): remove highlightedLines * refactor(docs): dropdown dx * refactor(docs): dropdown dx * refactor(docs): date-picker dx (heroui-inc#4103) * refactor(docs): date-picker dx * fix(docs): import paths * refactor(docs): date-range-picker dx (heroui-inc#4104) * refactor(docs): date-range-picker dx * fix(docs): date-range-picker dx * refactor(docs): drawer dx (heroui-inc#4109) * refactor(docs): drawer dx * fix(docs): indentation * refactor(docs): make icon collapsible --------- Co-authored-by: աӄա <[email protected]> Co-authored-by: Ryo Matsukawa <[email protected]>

vercel · 2025-01-29T14:42:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heroui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 29, 2025 2:42pm
heroui-sb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 29, 2025 2:42pm

changeset-bot · 2025-01-29T14:42:35Z

🦋 Changeset detected

Latest commit: c221d07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@nextui-org/select	Patch
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-01-29T14:42:36Z

@wingkwong is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-01-29T14:42:41Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

217 files out of 300 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

abhinav700 · 2025-01-29T14:43:38Z

@wingkwong I have not synced the branch yet because of mege conflicts. Should I resolve them?

wingkwong · 2025-01-29T16:02:24Z

your branch is probably outdated since previously it was pointing to beta branch. suggest to branch out from our canary and add the changes back.

abhinav700 · 2025-01-29T17:02:31Z

@wingkwong ok, will work on it

abhinav700 and others added 30 commits September 12, 2024 10:16

feat(select): add core logic for isClearable

40579f1

fix: fix alignment for clear button in select component

3954594

docs: add docs for clear button, isClearable, onClear

798ee73

Merge branch 'nextui-org:canary' into adding-isClearable-to-select

16334a9

chore: lint the code

6c0d2a3

chore: add changeset

c683694

chore: remove case for isClearable=false from docs and story

179b530

chore(select): code refactor

5635e4f

Merge branch 'nextui-org:canary' into adding-isClearable-to-select

e7f481e

Merge branch 'nextui-org:canary' into adding-isClearable-to-select

961b942

chore(select): update logic for clear button and add docs

2d74e6d

Merge branch 'canary' into adding-isClearable-to-select

5d112ac

chore(select): implement wingkwong's suggestions

450c77d

docs(select): pass onclear property to clear button

60ecd78

chore(select): theme version update, docs update

5f49a0d

Merge branch 'nextui-org:canary' into adding-isClearable-to-select

4c7b06e

fix(select): fix the focus behaviour of the clear button

50def02

chore(pre-release): enter pre-release mode

c94445e

fix(theme): apply tw nested group (heroui-inc#3909)

ad6393a

* chore(changset): add changeset * fix(theme): apply nested group to table * chore(docs): update table bottomContent code

fix: changeset

2339a27

fix: changeset

fee3bdc

fix: changeset

907dc13

fix: changeset

4640f16

fix: changeset

3d2cfb3

fix: pkg versions

dab9817

fix: changeset

4527f16

fix: drawer peer dep

7e814ad

chore: update plop components tempalte

e728371

ci(changesets): version packages (beta) (heroui-inc#3988)

23d24e0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fix: pre-release workflow

6549645

ryo-manba and others added 21 commits November 27, 2024 16:51

docs: add forms guide (heroui-inc#4155)

040c636

Co-authored-by: Ryo Matsukawa <[email protected]>

chore: routes updated

542a986

ci(changesets): version packages (beta) (heroui-inc#4151)

32ade62

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Merge branch 'canary' into beta/release-next

c4acc91

chore: fix indentation

cd629d9

fix(changeset): package not be found

476d418

ci(changesets): version packages (beta) (heroui-inc#4158)

50a4d56

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fix(select): controlled isInvalid prop (heroui-inc#4082)

1e05a72

* fix(select): controlled isInvalid prop * chore: add changeset * Merge branch 'beta/release-next' into pr/4082 --------- Co-authored-by: WK Wong <[email protected]>

ci(changesets): version packages (beta) (heroui-inc#4159)

197b2a6

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore(changeset): bump all versions

9869f2b

ci(changesets): version packages (beta) (heroui-inc#4160)

ffc1b66

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fix(deps): missing peer / dev dependency for framer-motion (heroui-in…

17bf657

…c#4161)

fix(system): align navigate function parameters with @react-aria (h…

c8f2ec8

…eroui-inc#4163)

chore(docs): remove incorrect info

04a82dd

ci(changesets): version packages (beta) (heroui-inc#4162)

8b28f79

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Merge branch 'beta/release-next' into pr/3746

968df46

chore(changeset): change to patch

bf029ab

refactor(docs): apply new structure to docs

c221d07

abhinav700 requested a review from jrgarciadev as a code owner January 29, 2025 14:42

wingkwong assigned abhinav700 Feb 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(select): add isClearable to select component #4760

feat(select): add isClearable to select component #4760

abhinav700 commented Jan 29, 2025

vercel bot commented Jan 29, 2025

changeset-bot bot commented Jan 29, 2025

vercel bot commented Jan 29, 2025

coderabbitai bot commented Jan 29, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

abhinav700 commented Jan 29, 2025

wingkwong commented Jan 29, 2025

abhinav700 commented Jan 29, 2025

feat(select): add isClearable to select component #4760

Are you sure you want to change the base?

feat(select): add isClearable to select component #4760

Conversation

abhinav700 commented Jan 29, 2025

vercel bot commented Jan 29, 2025

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

vercel bot commented Jan 29, 2025

coderabbitai bot commented Jan 29, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

abhinav700 commented Jan 29, 2025

wingkwong commented Jan 29, 2025

abhinav700 commented Jan 29, 2025