Skip to content

Commit

Permalink
fix: errors silently ignored when deleting resources
Browse files Browse the repository at this point in the history
  • Loading branch information
phm07 committed Jun 26, 2024
1 parent dcba0ca commit fdffdc9
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion internal/cmd/base/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,13 @@ func (dc *DeleteCmd) Run(s state.State, cmd *cobra.Command, args []string) error
}
}

for _, result := range results {
if result.Error != nil {
errs = append(errs, result.Error)
}
}

if len(actions) > 0 {
// TODO: We do not check when an action fail for a specific resource
if err := s.WaitForActions(cmd, s, actions...); err != nil {
errs = append(errs, err)
}
Expand Down

0 comments on commit fdffdc9

Please sign in to comment.