Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add --wait flag to "shutdown" command #569

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Oct 19, 2023

As described in #489

@phm07 phm07 added the feature label Oct 19, 2023
@phm07 phm07 self-assigned this Oct 19, 2023
@phm07 phm07 requested a review from a team as a code owner October 19, 2023 12:43
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice 🚀 Only got one question/nit

internal/cmd/server/shutdown.go Outdated Show resolved Hide resolved
@phm07 phm07 force-pushed the server-wait-for-shutdown branch from 371f1d3 to 6446437 Compare October 19, 2023 13:05
@phm07 phm07 merged commit 3ce048c into main Oct 19, 2023
3 checks passed
@phm07 phm07 deleted the server-wait-for-shutdown branch October 19, 2023 13:10
phm07 pushed a commit that referenced this pull request Oct 25, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.39.0](v1.38.3...v1.39.0)
(2023-10-25)


### Features

* add --enable-protection flag to "create" commands
([#567](#567))
([e313e69](e313e69))
* add "all list" command to list all resources in the project
([6d3b064](6d3b064))
* **iso:** allow to filter list by type (public, private)
([#573](#573))
([140cbc3](140cbc3))
* **primary-ip:** enable/disable-protection accept levels as arguments
([#564](#564))
([b11e223](b11e223))
* **server:** add --enable-backup flag to "create" command
([#568](#568))
([15adee0](15adee0))
* **server:** add --wait flag to "shutdown" command
([#569](#569))
([3ce048c](3ce048c))


### Bug Fixes

* **floating-ip:** list command only returns first 50 entries
([#574](#574))
([f3fa881](f3fa881))
* **image:** list does not parse "type" flag correctly
([#578](#578))
([9a0487a](9a0487a))
* list outputs null instead of empty array when listing in JSON
([#579](#579))
([93bed7e](93bed7e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants