Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency go to v1.21.5 #601

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 6, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
go (source) golang patch 1.21.1 -> 1.21.5

Release Notes

golang/go (go)

v1.21.5

v1.21.4

v1.21.3

v1.21.2


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner November 6, 2023 08:03
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think its necessary to bump the minimum version to latest go. This might hinder downstream disstributions from building if they do not have the latest and greatest go. On the other side Go 1.21 introduced new toolchain management that will automatically download a matching Go version.

@jooola
Copy link
Member

jooola commented Nov 6, 2023

We introduced the patch part of the version in 368bfae#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

I am also in favor of removing the patch part of the version.

@renovate renovate bot changed the title deps: update dependency go to v1.21.3 deps: update dependency go to v1.21.4 Nov 7, 2023
@renovate renovate bot force-pushed the renovate/go-1.x branch 2 times, most recently from d282c6c to d9a8836 Compare November 9, 2023 07:16
@renovate renovate bot changed the title deps: update dependency go to v1.21.4 deps: update dependency go to v1.21.5 Dec 5, 2023
@renovate renovate bot force-pushed the renovate/go-1.x branch from d9a8836 to 1f1de3b Compare December 5, 2023 19:42
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (855cd19) 31.62% compared to head (1f1de3b) 31.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   31.62%   31.62%           
=======================================
  Files         171      171           
  Lines        7855     7855           
=======================================
  Hits         2484     2484           
  Misses       5088     5088           
  Partials      283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola closed this Dec 11, 2023
@renovate renovate bot deleted the renovate/go-1.x branch December 11, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants