-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add Codecov to check test coverage #611
Conversation
b3a45aa
to
879168a
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add this to our existing test runs?
Line 43 in 1143e07
run: go test -v -race ./... |
If I remember correctly, codecov will fail the pipelines if the coverage status checks fail, e.g. coverage is less than 80%. Maybe we want to wait a bit before we enable such check to make such we actually have the required coverage. See: Also, we might need to enable the carryforward flags, but I am not sure if we have split tests in the CLI (unit/e2e) ? https://docs.codecov.com/docs/carryforward-flags Maybe we can start with ---
coverage:
status:
project: off # Or on is we have enough covrage ?
patch: off |
As far as I understood Codecov, Carryforward Flags are for setups where you only run a subset of tests (eg. only for changed files). We always run all tests. For different test suites you would use "flags": https://github.com/apricote/Listory/blob/25b738a246d380f1c526eb1de01cd146b0b3237f/.github/workflows/ci.yaml#L27 RE Status Checks, I would also prefer not to enable them. But I think we can do this organization wide at https://app.codecov.io/account/gh/hetznercloud/yaml/ instead of copying this in every repo. |
No description provided.