fix: make JSON/YAML outputs consistent #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very nice already! I noticed that all |
|
I don't think this is possible. You would need generic structs and generic type casts, none of which is possible in Go as of now. |
phm07
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 43.75% 46.27% +2.51%
==========================================
Files 171 171
Lines 7885 7456 -429
==========================================
Hits 3450 3450
+ Misses 4012 3583 -429
Partials 423 423 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Dec 13, 2023
phm07
changed the title
phm07
pushed a commit
that referenced
this pull request
Dec 13, 2023
🤖 I have created a release *beep* *boop* --- ## [1.41.0](v1.40.0...v1.41.0) (2023-12-13) ### Features * allow YAML output ([#628](#628)) ([87552d2](87552d2)) * **server:** allow to filter list by server status ([#629](#629)) ([1cb51f2](1cb51f2)), closes [#623](#623) ### Bug Fixes * make JSON/YAML outputs consistent ([#622](#622)) ([43944b8](43944b8)) * **server:** properly format request-console JSON output ([#626](#626)) ([40641b6](40641b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes the new
hcloud -> schemaconversion methods introduced in hetznercloud/hcloud-go#343 to reduce boilerplate code and enforce consistent schema conversions (in combination with hetznercloud/hcloud-go#349 & hetznercloud/hcloud-go#348)Fixes #461