Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prefer go-version-file option for actions/setup-go #653

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

wheinze
Copy link
Contributor

@wheinze wheinze commented Dec 21, 2023

In order to automatically align the Go version with the one used in development, I would suggest to prefer the go-version-file option of the setup action, so the Go version does not need to be managed manually.

PS: It might be meaningful to think of introducing a test-matrix for .github/workflows/ci.yml, so the officially supported Go versions are checked. If this is something you consider to do, I'm willing to file a subsequent PR for this ;)

@wheinze wheinze requested a review from a team as a code owner December 21, 2023 00:28
@wheinze wheinze changed the title ci: prefer go-version-file option for ?actions/setup-go` ci: prefer go-version-file option for actions/setup-go Dec 21, 2023
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, this change does make sens in the context of this project.

The CLI doesn't have the same go compatibility constraints as libraries, so I prefer not to introduce a test matrix for different version of go for now.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5a2dbb2) 45.94% compared to head (450a436) 45.98%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/cmd/certificate/create.go 78.57% 2 Missing and 1 partial ⚠️
internal/cmd/network/create.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/volume/create.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/util/util.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   45.94%   45.98%   +0.03%     
==========================================
  Files         171      171              
  Lines        7517     7514       -3     
==========================================
+ Hits         3454     3455       +1     
+ Misses       3623     3616       -7     
- Partials      440      443       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wheinze
Copy link
Contributor Author

wheinze commented Dec 21, 2023

The CLI doesn't have the same go compatibility constraints as libraries, so I prefer not to introduce a test matrix for different version of go for now.

Alright :)

@jooola jooola merged commit cc675b1 into hetznercloud:main Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants