Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: assign version using release-please #654

Merged
merged 4 commits into from
Dec 22, 2023
Merged

ci: assign version using release-please #654

merged 4 commits into from
Dec 22, 2023

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Dec 22, 2023

This PR changes version number output to the following:

Release

$ hcloud version
hcloud 1.23.4

goreleaser --snapshot

$ hcloud version
hcloud 1.23.4-dev+<short commit id>

go build/go install

$ hcloud version
hcloud 1.23.4-dev

Closes #636

@phm07 phm07 self-assigned this Dec 22, 2023
@phm07 phm07 requested a review from a team as a code owner December 22, 2023 14:37
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (468ef81) 45.98% compared to head (abefbb1) 45.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files         171      171           
  Lines        7514     7514           
=======================================
  Hits         3455     3455           
  Misses       3616     3616           
  Partials      443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.goreleaser.yml Outdated Show resolved Hide resolved
internal/version/version.go Outdated Show resolved Hide resolved
@jooola jooola changed the title ci: assign version string using release-please and GoReleaser ci: assign version using release-please Dec 22, 2023
@jooola jooola merged commit af9dec4 into main Dec 22, 2023
3 checks passed
@jooola jooola deleted the version-string branch December 22, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: update version number string with release please
2 participants