Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(primary-ip): make set-rdns consistent with other commands #686

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 31, 2024

Since hetznercloud/hcloud-go@41a4c5a Primary IPs support the RDNSSupporter interface, so the base.SetRdnsCmd can be used for Primary IPs to make them consistent with other subcommands.

@phm07 phm07 self-assigned this Jan 31, 2024
@phm07 phm07 requested a review from a team as a code owner January 31, 2024 12:31
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f31bb6e) 45.46% compared to head (6c66854) 45.32%.

Files Patch % Lines
internal/cmd/primaryip/set_rdns.go 50.00% 4 Missing ⚠️
internal/cmd/primaryip/primaryip.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   45.46%   45.32%   -0.15%     
==========================================
  Files         179      179              
  Lines        7890     7855      -35     
==========================================
- Hits         3587     3560      -27     
+ Misses       3846     3842       -4     
+ Partials      457      453       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit e8f3620 into main Jan 31, 2024
3 checks passed
@phm07 phm07 deleted the refactor-primaryip-changedns branch January 31, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants