Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore mock_gen.go #713

Merged
merged 1 commit into from
Mar 12, 2024
Merged

chore: restore mock_gen.go #713

merged 1 commit into from
Mar 12, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Mar 12, 2024

This file was erroneously deleted in #672

This file was erroneously deleted in #672
@phm07 phm07 self-assigned this Mar 12, 2024
@phm07 phm07 requested a review from a team as a code owner March 12, 2024 13:42
@phm07
Copy link
Contributor Author

phm07 commented Mar 12, 2024

To prevent this in the future, we should set up a CI pipeline where all generated files are deleted and re-generated and then it is checked that the diff is empty. That would also detect possible changes in generated files.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.78%. Comparing base (4712950) to head (63d49f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   58.78%   58.78%           
=======================================
  Files         179      179           
  Lines        6536     6536           
=======================================
  Hits         3842     3842           
  Misses       2087     2087           
  Partials      607      607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit b9265f4 into main Mar 12, 2024
3 checks passed
@phm07 phm07 deleted the mock-gen branch March 12, 2024 13:57
phm07 added a commit that referenced this pull request Mar 13, 2024
This PR adds a CI check that ensures all generated files are present and
up-to-date.
See #713

---------

Co-authored-by: pauhull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants