Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add end to end testing #785

Merged
merged 15 commits into from
Sep 23, 2024
Merged

test(e2e): add end to end testing #785

merged 15 commits into from
Sep 23, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jun 19, 2024

This PR adds end to end tests. Tests are located in test/e2e/. The HCLOUD_TOKEN environment variable should contain an API token to an empty project for the tests to work.

@phm07 phm07 requested a review from a team as a code owner June 19, 2024 13:22
@phm07 phm07 marked this pull request as draft June 19, 2024 13:30
@phm07 phm07 force-pushed the e2e-tests branch 2 times, most recently from a16e47c to 2545cff Compare July 4, 2024 08:24
@phm07 phm07 force-pushed the e2e-tests branch 2 times, most recently from a8ec9e8 to 089eb50 Compare July 11, 2024 12:12
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.45%. Comparing base (74e3ae5) to head (9396f76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/e2e/variables.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
+ Coverage   66.41%   71.45%   +5.04%     
==========================================
  Files         242      243       +1     
  Lines        8727     8731       +4     
==========================================
+ Hits         5796     6239     +443     
+ Misses       2218     1824     -394     
+ Partials      713      668      -45     
Flag Coverage Δ
e2e 43.91% <50.00%> (?)
unit 66.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 self-assigned this Sep 9, 2024
@phm07 phm07 added the test label Sep 9, 2024
@phm07 phm07 marked this pull request as ready for review September 9, 2024 13:40
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the general refactoring into a separate commit/PR?

@phm07 phm07 changed the base branch from main to e2e-test-preparation September 12, 2024 10:58
.github/workflows/ci.yml Show resolved Hide resolved
e2e_test/combined_test.go Outdated Show resolved Hide resolved
e2e_test/firewall_test.go Outdated Show resolved Hide resolved
e2e_test/combined_test.go Outdated Show resolved Hide resolved
e2e_test/combined_test.go Outdated Show resolved Hide resolved
Base automatically changed from e2e-test-preparation to main September 16, 2024 11:30
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/e2e_test.yml Show resolved Hide resolved
.github/workflows/e2e_test.yml Outdated Show resolved Hide resolved
e2e_test/combined_test.go Outdated Show resolved Hide resolved
e2e_test/network_test.go Outdated Show resolved Hide resolved
@phm07 phm07 merged commit 120aa03 into main Sep 23, 2024
6 checks passed
@phm07 phm07 deleted the e2e-tests branch September 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants