Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(firewall): move duplicated rule parsing code into own functions #796

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jun 26, 2024

No description provided.

@phm07 phm07 added the refactor label Jun 26, 2024
@phm07 phm07 self-assigned this Jun 26, 2024
@phm07 phm07 requested a review from a team as a code owner June 26, 2024 15:21
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 64.64646% with 35 lines in your changes missing coverage. Please review.

Project coverage is 59.69%. Comparing base (474b945) to head (5475367).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/cmd/firewall/add_rule.go 61.22% 16 Missing and 3 partials ⚠️
internal/cmd/firewall/create.go 73.17% 5 Missing and 6 partials ⚠️
internal/cmd/firewall/delete_rule.go 25.00% 1 Missing and 2 partials ⚠️
internal/cmd/firewall/replace_rules.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   59.73%   59.69%   -0.04%     
==========================================
  Files         210      210              
  Lines        7641     7598      -43     
==========================================
- Hits         4564     4536      -28     
+ Misses       2435     2424      -11     
+ Partials      642      638       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 force-pushed the refactor-firewall-rules-parsing branch from f62b9aa to 76f2331 Compare June 26, 2024 16:31
@phm07 phm07 changed the title refactor(firewall): move duplicated rule parsing code into own function refactor(firewall): move duplicated rule parsing code into own functions Jun 26, 2024
@phm07 phm07 requested a review from jooola June 26, 2024 16:35
@phm07 phm07 merged commit 12354bb into main Jun 27, 2024
5 checks passed
@phm07 phm07 deleted the refactor-firewall-rules-parsing branch June 27, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants