Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update golang docker tag to v1.22 #813

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 11, 2024

This PR contains the following updates:

Package Type Update Change
golang image minor 1.21 -> 1.22

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner July 11, 2024 13:43
@jooola
Copy link
Member

jooola commented Jul 11, 2024

Renovate seem to struggle because it is trying to update the devcontainers files: https://github.com/hetznercloud/cli/blob/main/.devcontainer/Dockerfile

I'd be in favor of removing the dev container files altogether.

@apricote
Copy link
Member

Renovate seem to struggle because it is trying to update the devcontainers files: https://github.com/hetznercloud/cli/blob/main/.devcontainer/Dockerfile

I'd be in favor of removing the dev container files altogether.

I am fine with that. As no one is actively using it, its always on the risk of being outdated and at that point it does not good to any new contributors.

@renovate renovate bot changed the title deps: update golang docker tag deps: update golang docker tag to v1.22 Jul 15, 2024
@renovate renovate bot force-pushed the renovate/golang-1.x branch from 611647a to a8f6e9b Compare July 15, 2024 10:17
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.47%. Comparing base (7f94cdf) to head (a8f6e9b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   59.47%   59.47%           
=======================================
  Files         210      210           
  Lines        7667     7667           
=======================================
  Hits         4560     4560           
  Misses       2458     2458           
  Partials      649      649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/golang-1.x branch from a8f6e9b to 6e86be7 Compare July 25, 2024 10:57
@renovate renovate bot force-pushed the renovate/golang-1.x branch from 6e86be7 to c67dd9d Compare August 13, 2024 21:35
@renovate renovate bot changed the title deps: update golang docker tag to v1.22 deps: update golang docker tag to v1.23 Aug 13, 2024
@renovate renovate bot changed the title deps: update golang docker tag to v1.23 deps: update golang docker tag to v1.22 Aug 19, 2024
@renovate renovate bot force-pushed the renovate/golang-1.x branch from c67dd9d to f318f79 Compare August 19, 2024 18:05
@renovate renovate bot force-pushed the renovate/golang-1.x branch from f318f79 to 9ce0d5c Compare September 4, 2024 09:07
@phm07
Copy link
Contributor

phm07 commented Sep 6, 2024

Closing for now, since we are still using the 1.21 toolchain. We can revisit this if we want to upgrade our toolchain.

@phm07 phm07 closed this Sep 6, 2024
Copy link
Contributor Author

renovate bot commented Sep 6, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (1.22). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/golang-1.x branch September 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants