Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build error in 0223f7d #850

Merged
merged 2 commits into from
Aug 26, 2024
Merged

chore: fix build error in 0223f7d #850

merged 2 commits into from
Aug 26, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Aug 26, 2024

The CI didn't catch this error, so it ended up in main.

@phm07 phm07 added the bug label Aug 26, 2024
@phm07 phm07 self-assigned this Aug 26, 2024
@phm07 phm07 requested a review from a team as a code owner August 26, 2024 08:07
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.49%. Comparing base (15b26d6) to head (e9bde91).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/cmd/certificate/retry.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   61.49%   61.49%   -0.01%     
==========================================
  Files         237      238       +1     
  Lines        8480     8502      +22     
==========================================
+ Hits         5215     5228      +13     
- Misses       2563     2568       +5     
- Partials      702      706       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote
Copy link
Member

Maybe golangci-lint only runs on changed files vs all files?

@apricote
Copy link
Member

Oh for this one I think it was just a missing rebase. Our CI only runs on the HEAD commit of the PR, not on the merge between main and HEAD. So if we make some changes in another PR they are not necessarily applied to existing pull requests.

@phm07 phm07 merged commit 2cf34e9 into main Aug 26, 2024
5 checks passed
@phm07 phm07 deleted the fix-0223f7d branch August 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants