Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add back check for uniqueness_error in network test #879

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Oct 9, 2024

The underlying issue in the API was fixed and we can now add the test back again.

@phm07 phm07 added the test label Oct 9, 2024
@phm07 phm07 self-assigned this Oct 9, 2024
@phm07 phm07 requested a review from a team as a code owner October 9, 2024 11:03
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (1f266ef) to head (d1c492a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #879   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files         244      244           
  Lines        8791     8791           
=======================================
  Hits         6297     6297           
  Misses       1826     1826           
  Partials      668      668           
Flag Coverage Δ
e2e 44.28% <ø> (ø)
unit 65.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit 4156544 into main Oct 9, 2024
6 checks passed
@phm07 phm07 deleted the e2e-network-uniqueness-error branch October 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants