feat: allow arbitrary length API tokens #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamushadenes
changed the title
apricote
approved these changes
Oct 7, 2024
apricote
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 34.54% 34.54%
=======================================
Files 19 19
Lines 1621 1621
=======================================
Hits 560 560
Misses 1027 1027
Partials 34 34 ☔ View full report in Codecov by Sentry. |
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 10, 2024
We[0] have developed a soon-to-be-open-source proxy that forces specific labels in order to provide scoped API access, and that doesn't expose the real API token. This was created to have better control of resources inside the same project (as API tokens currently lack granularity), and to be able to use a single project securely, given that it isn't possible to create a project via the API. One of it's operating modes is using JWT as a virtual self-validating token, which can't have a fixed size. This support is required to make full use of it inside a Kubernetes cluster. As the upstream Hetzner Cloud tokens might also change in length in the future, the error was changed to a warning log. [0] https://github.com/altinity
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.0...v2.10.0) (2024-10-29) ### Features * add support & tests for Kubernetes 1.31 ([#721](#721)) ([85035b9](85035b9)) * allow arbitrary length API tokens ([#724](#724)) ([61c3a0e](61c3a0e)) * allow passing mkfs format options via storage class parameters ([#747](#747)) ([4b9aa4e](4b9aa4e)) * change XFS default options to support older kernels ([#747](#747)) ([4b9aa4e](4b9aa4e)) * drop tests for Kubernetes 1.27 ([#722](#722)) ([d46a54b](d46a54b)) * force pods with volumes to be scheduled on Cloud servers ([#743](#743)) ([702fe01](702fe01)) * fstype is directly passed to mkfs: mkfs.<fstype> ([#749](#749)) ([173bf2f](173bf2f)) * support for SELinux mount ([#756](#756)) ([719247e](719247e)), closes [#582](#582) * Support SINGLE_NODE_MULTI_WRITER capability ([#725](#725)) ([cd53c23](cd53c23)), closes [#327](#327) * **swarm:** removed workaround support for mock staging/unstaging ([#746](#746)) ([465ec21](465ec21)) ### Bug Fixes * do not log sensitive mount options ([#755](#755)) ([0b6e860](0b6e860)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
lukasmetzner
pushed a commit
that referenced
this pull request
Nov 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.0...v2.10.0) (2024-10-29) ### Features * add support & tests for Kubernetes 1.31 ([#721](#721)) ([85035b9](85035b9)) * allow arbitrary length API tokens ([#724](#724)) ([61c3a0e](61c3a0e)) * allow passing mkfs format options via storage class parameters ([#747](#747)) ([4b9aa4e](4b9aa4e)) * change XFS default options to support older kernels ([#747](#747)) ([4b9aa4e](4b9aa4e)) * drop tests for Kubernetes 1.27 ([#722](#722)) ([d46a54b](d46a54b)) * force pods with volumes to be scheduled on Cloud servers ([#743](#743)) ([702fe01](702fe01)) * fstype is directly passed to mkfs: mkfs.<fstype> ([#749](#749)) ([173bf2f](173bf2f)) * support for SELinux mount ([#756](#756)) ([719247e](719247e)), closes [#582](#582) * Support SINGLE_NODE_MULTI_WRITER capability ([#725](#725)) ([cd53c23](cd53c23)), closes [#327](#327) * **swarm:** removed workaround support for mock staging/unstaging ([#746](#746)) ([465ec21](465ec21)) ### Bug Fixes * do not log sensitive mount options ([#755](#755)) ([0b6e860](0b6e860)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have developed a soon-to-be-open-source proxy that forces specific labels in order to provide scoped API access, and that doesn't expose the real API token. This was created to have better control of resources inside the same project (as API tokens currently lack granularity), and to be able to use a single project securely, given that it isn't possible to create a project via the API.
One of it's operating modes is using JWT as a virtual self-validating token, which can't have a fixed size.
This support is required to make full use of it inside a Kubernetes cluster.
The feature is behind a default-false flag so it shouldn't interfere with current behavior.
Related
kubernetes/autoscaler#7285
hetznercloud/hcloud-cloud-controller-manager#752