Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): Optional graceful shutdown before deleting servers #755

Merged
merged 9 commits into from
Sep 20, 2023
Merged

feat(server): Optional graceful shutdown before deleting servers #755

merged 9 commits into from
Sep 20, 2023

Conversation

LionC
Copy link
Contributor

@LionC LionC commented Sep 16, 2023

Solves #751

@apricote apricote changed the title Optional server shutdown feat(server): Optional graceful shutdown before deleting servers Sep 18, 2023
apricote
apricote requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with the docs, otherwise this looks great :)

website/docs/d/server.html.md Outdated Show resolved Hide resolved
@LionC LionC requested a review from apricote September 20, 2023 08:43
@LionC LionC marked this pull request as ready for review September 20, 2023 08:47
@LionC
Copy link
Contributor Author

LionC commented Sep 20, 2023

@apricote thanks for the approval. The failing check looks like a CI setup problem to me.

Can you give me an idea on when this will be available in a release? I want to use the feature in our project :-)

@apricote
Copy link
Member

Yea, E2E CI is expected to fail right now for external contributors. I tested your previous changes locally, so I think this should be good to go. E2E tests will then run in main.

@apricote apricote merged commit 0c477a3 into hetznercloud:main Sep 20, 2023
@hcloud-bot hcloud-bot mentioned this pull request Sep 18, 2023
Merged
@apricote
Copy link
Member

Can you give me an idea on when this will be available in a release? I want to use the feature in our project :-)

I can publish a new release once the main pipeline succeeded.

@LionC LionC deleted the optional-server-shutdown branch September 20, 2023 09:05
apricote added a commit that referenced this pull request Sep 20, 2023
@apricote
test: fix broken e2e test related to #755
2b74a1d 
We do not need to verify the import state on attributes that are
terraform internal.
@apricote apricote mentioned this pull request Sep 20, 2023
Merged
@apricote
Copy link
Member

Looks like I was wrong and it actually broke the e2e tests. Pushed a fix at #756.

apricote added a commit that referenced this pull request Sep 20, 2023
@apricote
test: fix broken e2e test related to #755 (#756)
446fbf1 
We do not need to verify the import state on attributes that are
terraform internal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LionC @apricote