refactor: move data.hcloud_ssh_key(s) to Plugin Framework #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
plugin-framework-ssh-keys
branch
from
3515bec to
3a685a3
Compare
apricote
force-pushed
the
plugin-framework-ssh-keys
branch
from
3a685a3 to
f664222
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
===========================================
+ Coverage 33.82% 69.41% +35.59%
===========================================
Files 54 56 +2
Lines 7649 7732 +83
===========================================
+ Hits 2587 5367 +2780
+ Misses 5044 1699 -3345
- Partials 18 666 +648
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jooola
force-pushed
the
plugin-framework-ssh-keys
branch
from
8bc9006 to
5ae39c3
Compare
71 tasks
jooola
force-pushed
the
plugin-framework-ssh-keys
branch
5 times, most recently
from
323e010 to
6715438
Compare
jooola
force-pushed
the
plugin-framework-ssh-keys
branch
from
6715438 to
1411652
Compare
This was referenced Feb 26, 2024
apricote
added a commit
that referenced
this pull request
Feb 26, 2024
All current resources use string IDs, but they are ints in hcloud-go. This util helps convert between them. Will be used by #817
apricote
force-pushed
the
plugin-framework-ssh-keys
branch
from
f6ae3c3 to
5e7878f
Compare
apricote
force-pushed
the
plugin-framework-ssh-keys
branch
2 times, most recently
from
cbace55 to
8579b2c
Compare
apricote
added a commit
that referenced
this pull request
Mar 11, 2024
We often have to convert between the Terraform Plugin Framework and hcloud-go representations for labels. Will be used by #817
Co-authored-by: Jonas Lammler <[email protected]>
apricote
force-pushed
the
plugin-framework-ssh-keys
branch
from
8579b2c to
12be994
Compare
apricote
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #752