perf(meta_generator): re-implement as a helper #3669
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
From the benchmark performed by @SukkaW , we can see cheerio—used by meta_generator filter—incurs significant perf cost. The feature was initially introduced by #3129.
Despite effort to improve the situation (#3667), the improvement was only minuscule.
As such, I propose to re-implement it as a helper instead, inspired by open_graph(). This approach doesn't require any dep, so it shouldn't incur perf cost.
However, as mentioned in #3663 (comment), this approach also means meta_generator will instead rely on adoption by the themes. Meaning, the adoption will be back to square one.
How to test
Pull request tasks