Add DAWN_USE_WINDOWS_UI option for Zig & MinGW compilers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2022
slimsag
force-pushed
the
sg/dawn-no-windows-ui
branch
2 times, most recently
from
abcfaa3 to
bcfcbd9
Compare
slimsag
changed the title
slimsag
force-pushed
the
sg/dawn-no-windows-ui
branch
from
bcfcbd9 to
fbd5098
Compare
slimsag
force-pushed
the
sg/dawn-no-windows-ui
branch
2 times, most recently
from
a65b0b1 to
5711e19
Compare
slimsag
force-pushed
the
sg/dawn-no-windows-ui
branch
2 times, most recently
from
38627e7 to
48e5dc5
Compare
slimsag
force-pushed
the
sg/dawn-no-windows-ui
branch
from
e92a967 to
88995bc
Compare
In Mach engine, we're compiling Dawn using Zig as a C/C++ compiler. Zig provides it's own libc implementation, build system, and system headers. Dawn today makes use of newer `windows.ui.*.h` headers introduced in more recent Windows versions. However, Zig relies on MinGW for it's system headers and it is not straightforward/desirable to use the official Windows SDK headers: Zig does not have these headers today. Since Dawn does not truly require these headers, we are using a preprocessor directive `DAWN_USE_WINDOWS_UI` to disable this functionality and enable compilation of Dawn with Zig/MinGW compilers. I have based the implementation on the existing `DAWN_USE_X11` and `DAWN_USE_WAYLAND` build configuration approaches. Signed-off-by: Stephen Gutekanst <[email protected]> Change-Id: If41cafb95666946115b58567fef753df3fbe940a
slimsag
force-pushed
the
sg/dawn-no-windows-ui
branch
from
88995bc to
73f249c
Compare
|
Merged upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pending CL being sent upstream to dawn.googlesource.com.
Status:
mainbranchHelps hexops/mach#86
In Mach engine, we're compiling Dawn using Zig as a C/C++ compiler. Zig provides it's own libc implementation, build system, and system headers.
Dawn today makes use of newer
windows.ui.*.hheaders introduced in more recent Windows versions. However, Zig relies on MinGW for it's system headers and it is not straightforward/desirable to use the official Windows SDK headers: Zig does not have these headers today.Since Dawn does not truly require these headers, we are using a preprocessor directive
DAWN_USE_WINDOWS_UIto disable this functionality and enable compilation of Dawn with Zig/MinGW compilers.I have based the implementation on the existing
DAWN_USE_X11andDAWN_USE_WAYLANDbuild configuration approaches.Signed-off-by: Stephen Gutekanst [email protected]