Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msl: improve binding matching #144

Merged
merged 3 commits into from
Feb 25, 2024
Merged

msl: improve binding matching #144

merged 3 commits into from
Feb 25, 2024

Conversation

emidoots
Copy link
Contributor

After this PR, all examples/sysgpu run under Metal, as well as foxxne's Aftersun game.

zig build test has a lot of GLSL test failures still, @alichraghi can you take a look? They are all like this:

error: 'test.vertexWriteGBuffers' failed: /Volumes/data/aftersun/mach-sysgpu/src/shader/codegen/glsl.zig:254:48: 0x1044c2f9f in emitGlobalVar (sysgpu-tests)
    const slot = glsl.bindings.get(key) orelse return error.NoBinding;
                                               ^
  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

src/shader/AstGen.zig Outdated Show resolved Hide resolved
Signed-off-by: Stephen Gutekanst <[email protected]>
@emidoots emidoots merged commit d6ed118 into main Feb 25, 2024
3 of 6 checks passed
@emidoots emidoots deleted the sg/metal branch February 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants