Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get MSVC builds working on x86_64; add MSVC build targets that link the dynamic MSVC runtime #12

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DouglasDwyer
Copy link

@DouglasDwyer DouglasDwyer commented Nov 22, 2024

This PR integrates the changes from #8 alongside some additional fixes. With these fixes, I am able to build the windows-msvc target on my machine.

In addition, this PR adds a new compilation flag (-Dmsvcrt_dynamic) that allows for linking the dynamic MSVC runtime (msvcrt.lib) rather than the static one (libcmt.lib). This is useful if you want to include machdxcompiler.lib in a project that already has other libraries linking to msvcrt.lib. I have also added CI builds that run with this flag enabled.

(Note: for easy proof that this is working, you can check out the CI builds on my fork of the project. The msvc targets for x86_64 now build!)

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

@DouglasDwyer DouglasDwyer changed the title Get MSVC builds working; add MSVC build targets that link the dynamic MSVC runtime Get MSVC builds working on x86_64; add MSVC build targets that link the dynamic MSVC runtime Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants