windowWillResize_toSize -> windowDidResize
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxnne
added a commit
to foxnne/mach
that referenced
this pull request
Dec 6, 2024
…here window size didn't include titlebar height. Depends on hexops/mach-objc#30
emidoots
approved these changes
Dec 8, 2024
emidoots
pushed a commit
to hexops/mach
that referenced
this pull request
Dec 8, 2024
…here window size didn't include titlebar height. Depends on hexops/mach-objc#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is necessary for hexops/mach#1317 and needs to be merged first so that the
build.zig.zoncan be updated.After more research, I found that
windowDidResizeis the better way to get the window size change, as we need to get the frame and useContentRectForFrameRectto make sure we are getting the correct window size with respect to the titlebar. This fixes an issue where resizing the window with the mouse, and then programmatically setting the window size would yield an incorrect window size.