-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: setup with new object system #1319
Conversation
Started working on X11. Will probably just put it in this PR if it's not merged by then. |
This is because something is not working with the new Mach Object system. It should be able to be fixed after messing around with it.
X11 now builds and runs |
Setting title now works on both backends. It does this by checking if the |
@@ -204,6 +187,17 @@ pub fn setCursorShape(_: *Linux, _: CursorShape) void { | |||
return; | |||
} | |||
|
|||
/// Checks for updates in mach object fields. Does nothing if window is not initialized. | |||
fn check_for_mach_updates(core: *Core, window_id: mach.ObjectID) void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove this function and inline this functionality where written
Setup Wayland to use new mach object system
wl_registry_add_listener
, rather than sharing a pointer to an instance ofLinux
with the Wayland server, pass the mach object system window id.Core
in the global scope ofWayland
so that listeners can use the provided window id and pointer toCore
to lookup the data for that window, modify it, and save it directly in the handler function. SeeregistryHandleGlobal()
definition for an example.core.windows
)Setup X11 to use new mach object system
Native
structCore
in the global scope. I think this can be avoided. Not sure if it's a good idea for X11Setup logs to appropriately explain the current status of the X11 implementation, which is not functional
Both X11 and Wayland work at runtime