This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Add caching for Bumblebee models in test workflow #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Mar 7, 2024
|
Not depending on versions sounds good. I remember I explicitly put them in cache key on Bumblebee CI, but I'm pretty sure that was to make sure we use separate cache for concurrent jobs (since we run tests for multiple versions), and that's not the case here anyway. And I don't remember if there was a specific issue or just me wanting to keep them separate. |
jonatanklosko
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided that model cache should not depend on OTP/Elixir versions, since Huggingface model params/configs should not depend on that, but if there's something I am missing there please do say