Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verifications of the registry cache ets table #1056

Merged
merged 1 commit into from
Dec 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add verifications of the registry cache ets table
ericmj committed Dec 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5c6151a66212c9770ab052f6dce5032a00e01695
9 changes: 7 additions & 2 deletions lib/hex/registry/server.ex
Original file line number Diff line number Diff line change
@@ -235,7 +235,7 @@ defmodule Hex.Registry.Server do
end

defp open_ets(path) do
case :ets.file2tab(path) do
case :ets.file2tab(path, verify: true) do
{:ok, tid} ->
tid

@@ -268,7 +268,12 @@ defmodule Hex.Registry.Server do
defp persist(tid, path) do
dir = Path.dirname(path)
File.mkdir_p!(dir)
:ok = :ets.tab2file(tid, String.to_charlist(path))

:ok =
:ets.tab2file(tid, String.to_charlist(path),
extended_info: [:object_count, :md5sum],
sync: true
)
end

defp purge_repo_from_cache(packages, %{ets: ets}) do
Loading