-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hex.registry add
Command
#931
base: main
Are you sure you want to change the base?
Conversation
lib/mix/tasks/hex.registry.ex
Outdated
names = | ||
for {name, %{updated_at: updated_at}} <- versions do | ||
%{name: name, updated_at: updated_at} | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum.map
is preferred here since it will error if the match fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change build
to match? If desired, I can include changes to build
in this PR or save them for a follow-up PR.
2607cbd
to
6d5871a
Compare
Hi @aj-foster! What's the status of this PR? |
Hi @ericmj I still need to respond to your comments and make changes based on the merged changes to hex_core. Apologies for not cleaning this up sooner. |
@aj-foster No worries, just checking in to get the status. I will leave the PR open and you can get to it if you get the time. Thank you! 💜 |
d3262e6
to
cd00ed8
Compare
Hi @ericmj — Made some updates to this PR. Hopefully I re-understood everything correctly, since it's been a while. 🙂 Just a few comments in the above threads to make sure I'm on the right track. |
24c6c48
to
0edaffc
Compare
This PR supersedes #920. See that PR for previous discussion.
In this PR, we add a
mix hex.registry add
command to the existing mix task. The purpose of this command is to allow private registry maintainers to add one or more packages to an existing registry without necessarily having all of the package tarballs present.At the time or writing, this PR is a minimal effort for the purpose of discussion. We have an opportunity to make larger changes to the
hex.registry
task to support future growth, if desired.Some topics to consider:
remove
,retire
)?create_local_registry
or even anin_local_registry
macro?With your guidance, I'm happy to contribute towards the right solution for the long term.