Add separate docs tarball limits and support infinity
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of separating the package and docs settings. But I think it's time to bump package sizes as well since we've had a few requests for it. Can we also have the option to skip the limits if the field is set to |
wojtekmach
changed the title
undefined
|
Good call, updated! |
wojtekmach
commented
Feb 29, 2024
src/hex_tarball.erl
Outdated
| @@ -601,6 +616,12 @@ gzip_no_header(Uncompressed) -> | |||
| %% Helpers | |||
| %%==================================================================== | |||
|
|
|||
| %% @private | |||
| valid_size(Binary, undefined) when is_binary(Binary) -> | |||
There was a problem hiding this comment.
another idea is to call the sentinel value infinity:
Suggested change
| valid_size(Binary, undefined) when is_binary(Binary) -> | |
| valid_size(Binary, infinity) when is_binary(Binary) -> |
but perhaps undefined is more often used for things like this.
|
@ericmj okay, let's bump package tarball sizes too. Same limit for both, 16 MiB compressed & 128 MiB uncompressed? |
ericmj
approved these changes
Feb 29, 2024
src/hex_tarball.erl
Outdated
| @@ -601,6 +616,12 @@ gzip_no_header(Uncompressed) -> | |||
| %% Helpers | |||
| %%==================================================================== | |||
|
|
|||
| %% @private | |||
| valid_size(Binary, undefined) when is_binary(Binary) -> | |||
wojtekmach
changed the title
undefinedinfinity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136
Closes #137
Before this patch we had a single tarball limit i.e. used for package and docs tarballs. The original issue is about bumping docs tarball limits so I'd focus on just that and wait for concrete uses cases for bumping the package tarball limit.
This additionally avoids the issue of someone publishing a bigger package tarball and users not being able to unpack it until they are on latest Hex (which would have bumped the limit).
WDYT?