Fix for retirement_reason spec.
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wojtekmach
reviewed
Jun 19, 2024
src/hex_api_release.erl
Outdated
| @@ -14,9 +14,9 @@ | |||
|
|
|||
| -type publish_params() :: [{replace, boolean()}]. | |||
|
|
|||
| -type retirement_reason() :: other | invalid | security | deprecated | renamed. | |||
| -type retirement_reason() :: binary(). | |||
There was a problem hiding this comment.
we don't use this type anymore anywhere, can you remove it while at it?
There was a problem hiding this comment.
Sure.
There was a problem hiding this comment.
|
Thank you! |
|
Would you be Ok to do a patch-release for this, to be able to run with an updated version next to erlef/rebar3_hex#338? Thanks. |
|
v0.10.3 is out! |
|
Thanks much, @wojtekmach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149.
Arguably, we could just have the code "accept" the binaries (as e.g.rebar3_hexis doing), and crash, since the spec is the intention that was passed, but with some backward compatibility I'm not sure the proposed solution will hurt.This is a draft pr to follow-up on the discussion for the linked issue.