Merge pull request #1687 from hunshcn/fix/plus

fix: sanitize "+" in uri
hey-api · Feb 10, 2025 · 1de7641 · 1de7641
2 parents 1df55ed + e8b3058
commit 1de7641
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/young-parents-float.md b/.changeset/young-parents-float.md
@@ -0,0 +1,5 @@
+---
+'@hey-api/openapi-ts': patch
+---
+
+sanitize "+" in uri to avoid plus in function name
diff --git a/packages/openapi-ts/src/openApi/common/parser/__tests__/sanitize.test.ts b/packages/openapi-ts/src/openApi/common/parser/__tests__/sanitize.test.ts
@@ -27,7 +27,7 @@ describe('sanitizeNamespaceIdentifier', () => {
     { expected: 'æbc', input: 'æbc' },
     { expected: 'æb-c', input: 'æb.c' },
     { expected: 'æb-c', input: '1æb.c' },
-    { expected: 'a-b-c--d--e', input: 'a/b{c}/d/$e' },
+    { expected: 'a-b-c--d---e', input: 'a/b{c}/d/$+e' },
   ])(
     'sanitizeNamespaceIdentifier($input) -> $expected',
     ({ expected, input }) => {

diff --git a/packages/openapi-ts/src/openApi/common/parser/sanitize.ts b/packages/openapi-ts/src/openApi/common/parser/sanitize.ts
@@ -27,7 +27,7 @@ export const sanitizeNamespaceIdentifier = (name: string) =>
   name
     .replace(/^[^\p{ID_Start}]+/u, '')
     .replace(/[^$\u200c\u200d\p{ID_Continue}]/gu, '-')
-    .replace(/\$/g, '-');
+    .replace(/[$+]/g, '-');
 
 export const sanitizeOperationParameterName = (name: string) => {
   const withoutBrackets = name.replace('[]', 'Array');