Simplifications simplify proof #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now also display the sum of all the sizes of the formulas before and after the simplification, and the time it took to simplify them and to compute their interpolants.
|
Thanks for the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a small theorem that states simplifications do not increase the number of symbols in formulas. This follows a conversation I had with @samvang and @hferee, in which we discussed adopting a more mathematical approach to simplifications by setting a goal and proving that our simplifications are a step toward that goal.
In this case, I used the same measure as the one used in the benchmark (number of symbols) to write the theorem, stating that the number of symbols in a simplified formula is always less than or equal to the original.
I don't see how we could get a better bound that isn't too implementation-dependent. Achieving that would probably require defining some notion of irreducibility, which I think would be hard to formalize in a useful and readable way.
The benchmark was also updated to output a last row in which summarizes the benchmark.