Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kirylchyk_added_flag_emoji_washingtonDC #489

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Conversation

Kirylchyk
Copy link
Contributor

As per opened enhancement ticket #467, adding a new emoji for Washington DC flag

@b-g
Copy link
Member

b-g commented Feb 19, 2024

Many thanks for this! But please change the aspect ration following the other flags. Also make sure that running npm run test-dev produces no errors, currently this is not the case.

kirylchyk_added_flag_emoji_washingtonDC_update01

revert package lock and update gitignore

remove white spaces in json
@Kirylchyk
Copy link
Contributor Author

Modified aspect ration and ran npm run test-dev. Got 55585 passing, 1 failed due to hexcode, but i think it's not an issue as I am adding non-standard emoji.

Thank you

@b-g
Copy link
Member

b-g commented Feb 22, 2024

Many thanks for the improvements! Close :) The stars seem to be distorted e.g. could you please fix them e.g. compare with https://en.wikipedia.org/wiki/Flag_of_Washington,_D.C. and the images below? Other than that, I think we are ready to merge.

2024-02-22 at 12 22

Screen Shot 2024-02-22 at 12 23 10

PS: I've fixed the hexcode issue, npm run test-dev is green now.

@Kirylchyk
Copy link
Contributor Author

Thank you for your feedback. Sending the latest version for the approval.

@b-g b-g merged commit cb496e0 into hfg-gmuend:master Feb 23, 2024
1 check passed
@b-g
Copy link
Member

b-g commented Feb 23, 2024

Many thanks! Merged.

@Kirylchyk
Copy link
Contributor Author

Thank you for your cooperation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants