Ensure that the string is truncated only when necessary. (Issue #54) #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @rafaelpetry for writing the issue #54.
The string was being truncated even when it was shorter than the length param (when using omission). This was happening because in order to make sure that the result (truncated string with the omission) wasn't larger than the desired length, the string was being truncated only to the desired length minus the omission length.
Now, it checks first if the string is shorter or equal than the desired length, if it is, it returns the string without processing. This way we don't have to mess with the truncation pipeline, and the string doesn't go through the process if it's not necessary.
Please let me know if you think that I should change or do something different to solve the issue!