Adding error handling route

public/css/main.css

@@ -55,7 +55,7 @@ p {
     font-size: small;
 }
 
-.not-found {
+.error {
     display: flex;
     justify-content: center;
     align-items: center;

src/controller/error.ts

@@ -0,0 +1,22 @@
+import { NextFunction, Request, Response } from 'express-serve-static-core';
+
+export function renderErrorPage(
+    req: Request,
+    res: Response,
+    _next: NextFunction,
+): void {
+    res.status(500).render('error', {
+        path: '/error',
+        isAdmin: req.session.isAdmin,
+    });
+}
+
+export function errorHandler(
+    error: any,
+    _req: Request,
+    res: Response,
+    _next: NextFunction,
+): void {
+    console.error(error);
+    res.redirect(`/error`);
+}

src/controller/login.ts

@@ -43,7 +43,11 @@ export async function login(
         return;
     }
 
-    const user = await userModel.getUserForLogin(username, password);
+    const user = await userModel
+        .getUserForLogin(username, password)
+        .catch((error) => {
+            next(new Error(error));
+        });
     if (!user) {
         req.flash('error', 'Invalid username or password!');
         renderLogin(req, res, next, {

src/controller/notFound.ts

@@ -1,7 +1,8 @@
 import { Request, Response } from 'express-serve-static-core';
 
-export function renderNotFoundPage(_req: Request, res: Response): void {
+export function renderNotFoundPage(req: Request, res: Response): void {
     res.status(404).render('not-found', {
         path: '/not-found',
+        isAdmin: req.session.isAdmin,
     });
 }

src/controller/signup.ts

@@ -70,7 +70,11 @@ export async function signup(
         return;
     }
 
-    if (await userModel.getUserByUsername(username)) {
+    if (
+        await userModel.getUserByUsername(username).catch((error) => {
+            next(new Error(error));
+        })
+    ) {
         req.flash('error', 'Username is already taken!');
         renderSignup(req, res, next, {
             statusCode: 422,
@@ -85,7 +89,11 @@ export async function signup(
         });
         return;
     }
-    if (await userModel.getUserByEmail(email)) {
+    if (
+        await userModel.getUserByEmail(email).catch((error) => {
+            next(new Error(error));
+        })
+    ) {
         req.flash('error', 'Email is already taken!');
         renderSignup(req, res, next, {
             statusCode: 422,
@@ -121,14 +129,11 @@ export async function signup(
         return;
     }
 
-    await userModel.createUser(
-        username,
-        firstName,
-        lastName,
-        email,
-        password,
-        username,
-    );
+    await userModel
+        .createUser(username, firstName, lastName, email, password, username)
+        .catch((error) => {
+            next(new Error(error));
+        });
 
     // Do not await the mailer
     mailer.sendMail({

src/routes/userRoutes.ts

@@ -12,9 +12,10 @@ import {
     switchLocation,
 } from '../controller/dashboard';
 import { renderAdminPage } from '../controller/admin';
-import { renderNotFoundPage } from '../controller/notFound';
 import validateEmptyBody from '../validators/validateEmptyBody';
 import validateSettings from '../validators/validateSettings';
+import { renderNotFoundPage } from '../controller/notFound';
+import { renderErrorPage } from '../controller/error';
 
 const userRouter = express.Router();
 
@@ -38,6 +39,8 @@ userRouter.post('/settings', validateSettings, saveSettings);
 
 userRouter.get('/not-found', renderNotFoundPage);
 
+userRouter.get('/error', renderErrorPage);
+
 // Middleware to redirect to /not-found
 userRouter.use((req, res) => {
     console.log(`Redirecting from ${req.url} to /not-found`);

src/server.ts

@@ -8,6 +8,7 @@ import knexConfig from './db/knexfile';
 import configRouter from './routes/configRoutes';
 import sessionRouter from './routes/sessionRoutes';
 import userRouter from './routes/userRoutes';
+import { errorHandler } from './controller/error';
 
 // Loading environment variables
 dotenv.config({ path: '../secrets/.env' });
@@ -22,6 +23,7 @@ db.migrate.latest().finally(() => {
     app.use(configRouter);
     app.use(sessionRouter);
     app.use(userRouter);
+    app.use(errorHandler);
 
     const privateKey = fs.readFileSync(
         path.join(__dirname, '..', 'secrets', 'cryptospace.key'),

views/error.ejs

@@ -0,0 +1,11 @@
+<%- include('includes/head.ejs') %>
+</head>
+
+<body>
+<%- include('includes/navigation.ejs') %>
+
+<div class="error">
+    <p>Error 500 - Something went wrong!</p>
+</div>
+
+<%- include('includes/end.ejs') %>

views/not-found.ejs

@@ -2,10 +2,10 @@
 </head>
 
 <body>
-    <%- include('includes/navigation.ejs') %>
-
-    <div class="not-found">
-        <p>Error 404 - Page Not Found</p>
-    </div>
+<%- include('includes/navigation.ejs') %>
 
-    <%- include('includes/end.ejs') %>
+<div class="error">
+    <p>Error 404 - Page Not Found</p>
+</div>
+
+<%- include('includes/end.ejs') %>