Add --fullpath option #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhatto
force-pushed
the
add-fullpath-option
branch
from
3596577 to
81fc668
Compare
cclarkedt
reviewed
Jan 2, 2025
Comment on lines
83
to
+89
| func checkOptionMatch(path string, info os.FileInfo, opts *ClocOptions) bool { | ||
| // check match directory & file options | ||
| if opts.ReNotMatch != nil && opts.ReNotMatch.MatchString(info.Name()) { | ||
| targetFile := info.Name() | ||
| if opts.Fullpath { | ||
| targetFile = path | ||
| } | ||
|
|
There was a problem hiding this comment.
Perhaps we should do filepath.Clean(path) to handle cases where ./dir/file.py is equal to dir/file.py?
There was a problem hiding this comment.
This path will be the value specified from gocloc's CLI options or the value of filepath.Walk in the specified directory.
If it is a value specified from the CLI option of gocloc, it should not be Cleaned because it will be a user input.
In the case of the value of filepath.Walk, it will be a Cleaned value and should not be Cleaned.
So we think Clean is not necessary here.
|
This feature will be great to use, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--fullpathoption to be enabled for the--matchand--not-matchoptions.While
--match/--not-matchoptions determined regex matches/not-matches only for basenames.When
--fullpathoption is specified, match/not-match are determined for the entire file path.ref: #93