This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
Remove enqueue as a callback #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that the enqueue action should be handle by who needs it, so it does not belongs to this project. I'm starting to move this behaviour into a service and with that said I think that the service should be responsable on asking for an enqueue. Also, I don't think that enqueue should be a private method. Maybe we need to handle this action from an admin page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the enqueue action should be handle by who
needs it, so it does not belongs to this project.
I'm starting to move this behaviour into a service and with
that said I think that the service should be responsable on
asking for an enqueue.
Also, I don't think that enqueue should be a private method.
Maybe we need to handle this action from an admin page.
Do not merge till we merge the new services into webapp