Skip to content

Commit

Permalink
Merge pull request #26 from hhimanshu/hhimanshu/dev-24-readme
Browse files Browse the repository at this point in the history
feat(DEV-24): update README.md
  • Loading branch information
hhimanshu authored Jul 6, 2021
2 parents 2be66f0 + ecd2ec0 commit 5335a77
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 12 deletions.
36 changes: 26 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
### What it contains
- ReactJS support with TypeScript
- Testing support using Jest and React Testing Library
- Formatting support using Prettier
- ESLint support
- Ability to collect code coverage via Jest
- Support for Storybook
- CI setup using GitHub Actions

### Commands
# React TypeScript Starter
Read more about why and list of all supported features [here](https://react-ts-starter-hhimanshu.vercel.app/)

## Commands
- `./setup.sh` to install dependencies.
- `yarn start` to develop locally.
- `yarn test` to test and see the code coverage.
Expand All @@ -18,3 +12,25 @@
- `yarn storybook` to start storybook in development mode.
- `yarn build-storybook` to create production build for storybook.
- `yarn start-prod-storybook` to serve production build for storybook on port `5858`.

## 3rd party setup
If you are planning to leverage the ecosystem as available in this repository, you need to setup your project to use
Vercel, Semantic Release and Renovate.

All these tools are easy to configure. Please find their documentation below

[Vercel - Deploy a project](https://vercel.com/docs#deploy-an-existing-project)

[Semantic Release - Setup](https://semantic-release.gitbook.io/semantic-release/usage/getting-started)

[Renovate Github App Installation](https://docs.renovatebot.com/install-github-app/)

## How tos
### How to import and use `SVG`?
```tsx
import Check from '../../../assets/check.svg'; // import
<Check /> // use
```

## Questions or Ideas?
Please [start a new discussion](https://github.com/hhimanshu/create-react-ts-starter/discussions)
2 changes: 1 addition & 1 deletion src/components/Home/Discussion/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const Discussion = () => {
);

return (
<Section title={'Have ideas?'} bgColor={'#F9F8F8'}>
<Section title={'Have ideas?'}>
<Button title={'Start a discussion'} onClick={openDiscussion} />
</Section>
);
Expand Down
2 changes: 1 addition & 1 deletion src/components/Home/GetStarted/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const GetStarted = () => {
window.open('https://github.com/hhimanshu/create-react-ts-starter#readme');

return (
<Section title={'Ready to get started?'}>
<Section title={'Ready to get started?'} bgColor={'#F9F8F8'}>
<Button title={'Follow README.md'} onClick={openReadMe} />
</Section>
);
Expand Down
18 changes: 18 additions & 0 deletions src/components/Home/NotIncluded/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import React from 'react';
import { Section } from '../Section';

export const NotIncluded = () => {
return (
<Section title={'Why no redux or CSS Framework included?'}>
<p>
When it comes to client state management or using a styling solution,
there are a lot of options available. Additionally, each team or
individual have their favorites tools or needs for the problem at hand.
</p>
<p>
This project does not assume or provides any opinion on those choices,
so you are free to bring your own solution!
</p>
</Section>
);
};
2 changes: 2 additions & 0 deletions src/components/Home/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@ import { Why } from './Why';
import { Features } from './Features';
import { GetStarted } from './GetStarted';
import { Discussion } from './Discussion';
import { NotIncluded } from './NotIncluded';

export const Home = () => {
return (
<Fragment>
<Header />
<Why />
<Features />
<NotIncluded />
<GetStarted />
<Discussion />
</Fragment>
Expand Down

1 comment on commit 5335a77

@vercel
Copy link

@vercel vercel bot commented on 5335a77 Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.