Support HHVM 3.24, require HHVM 3.23

.hhconfig

@@ -1 +1,3 @@
 assume_php=false
+enable_experimental_tc_features = safe_pass_by_ref, safe_array, safe_vector_array, contextual_inference
+ignored_paths = [ "vendor/.+/tests/.+" ]

.travis.sh

@@ -1,8 +1,6 @@
 #!/bin/sh
 set -ex
 hhvm --version
-apt-get update -y
-apt-get install -y wget curl git
 curl https://getcomposer.org/installer | hhvm -d hhvm.jit=0 --php -- /dev/stdin --install-dir=/usr/local/bin --filename=composer
 
 cd /var/source
@@ -14,13 +12,8 @@ bin/hh-autoload
 hh_server --check $(pwd)
 hhvm -d hhvm.jit=0 vendor/bin/phpunit \
   --bootstrap=vendor/hh_autoload.php tests/
+hhvm -d hhvm.jit=0 -d hhvm.php7.all=1 vendor/bin/phpunit \
+  --bootstrap=vendor/hh_autoload.php tests/
 
-HHVM_VERSION=$(hhvm --php -r 'echo HHVM_VERSION_ID;' 2>/dev/null);
-if [ $HHVM_VERSION -ge 32002 ]; then
-  hhvm -d hhvm.php7.all=1 -d hhvm.jit=0 vendor/bin/phpunit tests/
-fi
-
-if [ $HHVM_VERSION -ge 32200 -a $HHVM_VERSION -lt 32300 ]; then
-  echo enable_experimental_tc_features = optional_shape_field, unknown_fields_shape_is_not_subtype_of_known_fields_shape >> .hhconfig
-  hh_server --check $(pwd)
-fi
+sed -i '/enable_experimental_tc_features/d' .hhconfig
+hh_server --check $(pwd)

.travis.yml

@@ -3,8 +3,6 @@ language: generic
 services:
  - docker
 env:
- - HHVM_VERSION=3.18-lts-latest
- - HHVM_VERSION=3.21-lts-latest
  - HHVM_VERSION=latest
  - HHVM_VERSION=nightly
 install:

src/HHClientFallbackHandler.php

@@ -32,7 +32,7 @@ protected function getCache(): ?self::TCache{
     $key = __CLASS__.'!cache';
     if (\apc_exists($key)) {
       $success = false;
-      $data = \apc_fetch($key, $success);
+      $data = \apc_fetch($key, &$success);
       if (!$success) {
         return null;
       }
@@ -194,7 +194,7 @@ private function lookupPathImpl(string $kind, string $name): ?string {
 
     $exit_code = null;
     $output = array();
-    $last = \exec($cmd, $output, $exit_code);
+    $last = \exec($cmd, &$output, &$exit_code);
     if ($exit_code !== 0) {
       return null;
     }

tests/RootImporterTest.php

@@ -64,7 +64,7 @@ public function testImportTree(
 
     $output = [];
     $exit_code = null;
-    $result = exec($cmd, $output, $exit_code);
+    $result = exec($cmd, &$output, &$exit_code);
 
     $contents = file_get_contents($tempfile);
     unlink($tempfile);

tests/ScannerTest.php

@@ -125,8 +125,8 @@ public function testParsersMatch(): void {
       $expected = $def_finder[$type];
       /* HH_IGNORE_ERROR[4051] */
       $actual = $fact_parse[$type];
-      ksort($expected);
-      ksort($actual);
+      ksort(&$expected);
+      ksort(&$actual);
       $this->assertEquals(
         array_filter($expected, $path ==> strpos($path, '/test') === false),
         array_filter($actual, $path ==> strpos($path, '/test') === false),