Ban varray/darray intrinsic in the typechecker

Summary: ^

Reviewed By: vassilmladenov

Differential Revision: D51563045

fbshipit-source-id: 87a6d5a73507f191407c504d82a0e8eab0c533f7

src/os/sockaddr_in.php

@@ -44,7 +44,7 @@ final public function getAddress(): in_addr {
   }
 
   final public function __debugInfo(): darray<string, mixed> {
-    return darray[
+    return dict[
       'port (host byte order)' => $this->port,
       'address (uint32)' => $this->address,
       'address (presentation format)' =>

src/os/sockaddr_in6.php

@@ -60,7 +60,7 @@ final public function getScopeID(): int {
   }
 
   final public function __debugInfo(): darray<string, mixed> {
-    return darray[
+    return dict[
       'port (host byte order)' => $this->port,
       'flow info (host byte order)' => $this->flowInfo,
       'scope ID (host byte order)' => $this->scopeID,

tests/async/PollTest.php

@@ -31,40 +31,40 @@ public static function provideTestInputs(
   ): varray<(varray<Awaitable<int>>, varray<int>, bool)> {
     $block = async (int $prio) ==> await RescheduleWaitHandle::create(0, $prio);
 
-    return varray[
+    return vec[
       // Empty
       tuple(
-        varray[],
-        varray[],
+        vec[],
+        vec[],
         false,
       ),
       // One eager success
       tuple(
-        varray[async { return 42; }],
-        varray[42],
+        vec[async { return 42; }],
+        vec[42],
         false,
       ),
       // One resumed success
       tuple(
-        varray[async { await $block(0); return 42; }],
-        varray[42],
+        vec[async { await $block(0); return 42; }],
+        vec[42],
         false,
       ),
       // One eager failure
       tuple(
-        varray[async { throw new Exception(); }],
-        varray[],
+        vec[async { throw new Exception(); }],
+        vec[],
         true,
       ),
       // One resumed failure
       tuple(
-        varray[async { await $block(0); throw new Exception(); }],
-        varray[],
+        vec[async { await $block(0); throw new Exception(); }],
+        vec[],
         true,
       ),
       // Combination
       tuple(
-        varray[
+        vec[
           async { return 1; },
           async { await $block(1); return 2; },
           async { return 3; },
@@ -73,7 +73,7 @@ public static function provideTestInputs(
           async { await $block(0); return 5; },
           async { return 6; },
         ],
-        varray[1, 3, 6, 5, 2],
+        vec[1, 3, 6, 5, 2],
         true,
       ),
     ];
@@ -85,7 +85,7 @@ public static function provideTestInputs(
     varray<int> $expected_results,
     bool $expected_exception,
   ): Awaitable<void> {
-    $results = varray[];
+    $results = vec[];
     $exception = false;
     try {
       foreach (Async\Poll::from($awaitables) await as $value) {
@@ -103,7 +103,7 @@ public static function provideTestInputs(
   }
 
   public async function testKeyed(): Awaitable<void> {
-    $poll = Async\KeyedPoll::from(darray[
+    $poll = Async\KeyedPoll::from(dict[
       'k1' => async {
         return 1;
       },
@@ -118,7 +118,7 @@ public static function provideTestInputs(
           break;
         case 'k2':
           expect($value)->toBePHPEqual(2);
-          $poll->addMulti(darray['k3' => async { return 3; }]);
+          $poll->addMulti(dict['k3' => async { return 3; }]);
           break;
         case 'k3':
           expect($value)->toBePHPEqual(3);

tests/c/CIntrospectTest.php

@@ -15,7 +15,7 @@
 final class CIntrospectTest extends HackTest {
 
   public static function provideTestAny(): varray<mixed> {
-    return varray[
+    return vec[
       tuple(
         Vector {2, 4, 6, 8, 9, 10, 12},
         $v ==> $v % 2 === 1,
@@ -39,18 +39,18 @@ public function testAny<T>(
   }
 
   public static function provideTestAnyWithoutPredicate(): varray<mixed> {
-    return varray[
+    return vec[
       tuple(
-        varray[],
+        vec[],
         false,
       ),
       tuple(
-        varray[null, 0, '0', ''],
+        vec[null, 0, '0', ''],
         false,
       ),
       tuple(
         HackLibTestTraversables::getIterator(
-          varray[null, 0, '0', '', 1],
+          vec[null, 0, '0', '', 1],
         ),
         true,
       ),
@@ -67,7 +67,7 @@ public function testAnyWithoutPredicate<T>(
 
   public static function provideTestContains(
   ): varray<(Traversable<mixed>, mixed, bool)> {
-    return varray[
+    return vec[
       tuple(
         vec[1, 2, 3, 4, 5],
         3,
@@ -109,13 +109,13 @@ public static function provideTestContains(
         true,
       ),
       tuple(
-        varray[dict[1 => 2, 3 => 4]],
+        vec[dict[1 => 2, 3 => 4]],
         dict[1 => 2, 3 => 4],
         true,
       ),
       tuple(
-        varray[varray[3]],
-        varray[4],
+        vec[vec[3]],
+        vec[4],
         false,
       ),
       tuple(
@@ -166,9 +166,9 @@ public function testContains<T>(
   }
 
   public static function provideTestContainsKey(): varray<mixed> {
-    return varray[
+    return vec[
       tuple(
-        darray[3 => 3],
+        dict[3 => 3],
         3,
         true,
       ),
@@ -210,8 +210,8 @@ public function testContainsKey<Tk as arraykey, Tv>(
   }
 
   public static function provideTestCount(): varray<mixed> {
-    return varray[
-      tuple(varray[], 0),
+    return vec[
+      tuple(vec[], 0),
       tuple(Vec\range(1, 10), 10),
       tuple(Set {1, 2}, 2),
       tuple(Vector {1, 2}, 2),
@@ -231,7 +231,7 @@ public function testCount<T>(
   }
 
   public static function provideTestEvery(): varray<mixed> {
-    return varray[
+    return vec[
       tuple(
         Vector {2, 4, 6, 8, 9, 10, 12},
         $v ==> $v % 2 === 0,
@@ -255,9 +255,9 @@ public function testEvery<T>(
   }
 
   public static function provideTestEveryWithoutPredicate(): varray<mixed> {
-    return varray[
+    return vec[
       tuple(
-        varray[],
+        vec[],
         true,
       ),
       tuple(
@@ -276,10 +276,10 @@ public function testEveryWithoutPredicate<T>(
   }
 
   public static function provideTestIsEmpty(): varray<mixed> {
-    return varray[
-      tuple(varray[], true),
-      tuple(varray[1], false),
-      tuple(darray['foo' => 'bar'], false),
+    return vec[
+      tuple(vec[], true),
+      tuple(vec[1], false),
+      tuple(dict['foo' => 'bar'], false),
       tuple(dict[], true),
       tuple(dict['foo' => 'bar'], false),
       tuple(vec[], true),

tests/c/CReduceTest.php

@@ -15,7 +15,7 @@
 final class CReduceTest extends HackTest {
 
   public static function provideTestReduce(): varray<mixed> {
-    return varray[
+    return vec[
       tuple(
         Set {'the', ' quick', ' brown', ' fox'},
         ($a, $s) ==> $a.$s,
@@ -24,14 +24,14 @@ public static function provideTestReduce(): varray<mixed> {
       ),
       tuple(
         HackLibTestTraversables::getIterator(
-          varray['the', ' quick', ' brown', ' fox'],
+          vec['the', ' quick', ' brown', ' fox'],
         ),
         ($a, $s) ==> $a.$s,
         '',
         'the quick brown fox',
       ),
       tuple(
-        varray['the', 'quick', 'brown', 'fox'],
+        vec['the', 'quick', 'brown', 'fox'],
         /* HH_FIXME[4297] The type of the lambda argument(s) could not be inferred */
         ($a, $s) ==> $a->add($s),
         Vector {},
@@ -51,7 +51,7 @@ public function testReduce<Tv, Ta>(
   }
 
   public static function provideTestReduceWithKey(): varray<mixed> {
-    return varray[
+    return vec[
       tuple(
         'dict',
         dict[1 => 2, 2 => 3, 3 => 4, 4 => 5],
@@ -60,7 +60,7 @@ public static function provideTestReduceWithKey(): varray<mixed> {
       ),
       tuple(
         'array',
-        darray[1 => 2, 2 => 3, 3 => 4, 4 => 5],
+        dict[1 => 2, 2 => 3, 3 => 4, 4 => 5],
         dict[1 => 0, 4 => 6, 8 => 10],
         dict[1 => 0],
       ),