Skip to content

Commit

Permalink
test: cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
hi-ogawa committed Sep 29, 2024
1 parent f61d981 commit f889464
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 10 deletions.
8 changes: 4 additions & 4 deletions examples/web-worker/e2e/basic.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ test("basic", async ({ page }) => {

test("erorr stack", async ({ page }) => {
// TODO:
// error event's stacktrace doesn't have sourcemap applied.
// it needs to be verified from devtools console error message.
// playwright's error stack doesn't have sourcemap applied.
// it needs to be manually verified from devtools console error message.
const errorPromise = page.waitForEvent("pageerror");
await page.goto("/?error-stack");
await page.goto("/?error");
const error = await errorPromise;
expect(error.message).toBe("test-error-stack");
expect(error.message).toBe("test-error");
});

test("worker in worker", async ({ page }) => {
Expand Down
13 changes: 8 additions & 5 deletions examples/web-worker/src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,19 @@ export function App() {
const worker = new Worker(workerUrl, { type: "module" });
worker.addEventListener("message", (e) => {
if (e.data.type === "ready") {
worker.postMessage({ type: "render" });
}
if (e.data.type === "render") {
setWorkerMessage(e.data.data);
if (window.location.search.includes("error-stack")) {
if (window.location.search.includes("error")) {
worker.postMessage({ type: "error" });
setWorkerMessage("See devtool console");
return;
}
if (window.location.search.includes("worker-in-worker")) {
worker.postMessage({ type: "worker-in-worker" });
return;
}
worker.postMessage({ type: "render" });
}
if (e.data.type === "render") {
setWorkerMessage(e.data.data);
}
if (e.data.type === "worker-in-worker") {
setWorkerMessage(e.data.data);
Expand Down
2 changes: 1 addition & 1 deletion examples/web-worker/src/worker/dep-error.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ export function depThrowError() {
}

function depThrowError2() {
throw new Error("test-error-stack");
throw new Error("test-error");
}

0 comments on commit f889464

Please sign in to comment.