Skip to content

Conversation

@sebersole
Copy link
Member

Move from JDK 21 to JDK 25 for CI builds.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you will also need to update the Jenkinsfile at the root of the repository:

  1. Update DEFAULT_JDK_VERSION, set it to 25.
  2. Add new BuildEnvironment( mainJdkVersion: '21', testJdkVersion: '21' ), just below the existing line for JDK 17.

@yrodiere
Copy link
Member

Also... you'll probably want to set this to 25, to require JDK 25 being used at build time?

orm.jdk.min=21

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 24, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [2529c1d, 13ad54a, b068bee]

› This message was automatically generated.

@sebersole
Copy link
Member Author

Also... you'll probably want to set this to 25, to require JDK 25 being used at build time?

orm.jdk.min=21

Perhaps? Unfortunately it depends what task(s) you are running. If you run Javadoc, then yes this is true.

I'll change it and see what happens :D

@sebersole
Copy link
Member Author

Also... you'll probably want to set this to 25, to require JDK 25 being used at build time?

orm.jdk.min=21

Perhaps? Unfortunately it depends what task(s) you are running. If you run Javadoc, then yes this is true.

I'll change it and see what happens :D

The 3 Oracle jobs using Graalvm need Java 21 (or 23, but...). So we have 2 options that I see:

  1. Make the change you suggest, which I think is a good one. However, it requires the "hack" of running those 3 Oracle jobs with -Porm.jdk.min=21
  2. Keep orm.jdk.min=21 in the settings but add some specific pre-checks to Javadoc tasks that check > 23 is being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants