-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-18229 Handle null owner key for collections #9700
base: 6.2
Are you sure you want to change the base?
Conversation
0ff8f46
to
cbc9ca7
Compare
@soul2zimate it looks like compilation is failing, could you please check? |
cbc9ca7
to
624a469
Compare
sure, missed the |
@soul2zimate looks like the build is still failing, are you going to look into it? |
sorry @mbladel I am on an unexpected PTO and I don't have my laptop nearby. There is no compilation error but it seems there are failed tests which I don't understand why. I can only investigate them next Monday. |
No problem, just let us know if you need help or if you won't be able to look into it yourself we can always give it a try. |
(cherry picked from commit 1f08501)
624a469
to
bf21824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mbladel, The Tests / Build/ ...
checks are passed. Can you check if this is good for you ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks @soul2zimate!
(cherry picked from commit 1f08501)
upstream PR: #8700
issue: https://hibernate.atlassian.net/browse/HHH-18229
[Backport HHH-18229 fix to downstream 6.2 branch]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.