Skip to content

display QR codes for device auth flows #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

display QR codes for device auth flows #93

wants to merge 2 commits into from

Conversation

@ccmtaylor
Copy link
Contributor

@ccmtaylor ccmtaylor commented Oct 14, 2025

use package rsc.io/qr to generate QR codes and display them in the terminal using ANSI escape codes.

Screenshot:
image

inspired by #41, but doesn't require installing a separate cli tool

@ccmtaylor
getDeviceToken: return error instead of calling Fatalln()
850067c 
the call site in main() exits on error, so this seems unnecessary here
@ccmtaylor ccmtaylor force-pushed the device-qrcode branch 2 times, most recently from 661e5c4 to 1726118 Compare October 14, 2025 19:22
@ccmtaylor
display QR codes for device flow authentication
3975945 
use package rsc.io/qr to generate QR codes and display them in the
terminal using ANSI escape codes.
@ccmtaylor
Copy link
Contributor Author

ccmtaylor commented Oct 14, 2025

tested with echo host=gitlab.com | go run . -device get

@hickford
Copy link
Owner

hickford commented Oct 17, 2025 •
edited
Loading

Super cool! Works for me too.

Before merging, I'll check the packaging implications for Debian and Fedora...

@hickford
Copy link
Owner

hickford commented Oct 18, 2025 •
edited
Loading

Fedora has 0.2.0 https://packages.fedoraproject.org/pkgs/golang-rsc-qr/golang-rsc-qr-devel/

Debian has an older, untagged version 0.0~git20161121.48b2ede https://packages.debian.org/source/sid/golang-rsc-qr ideally that should be updated

@ccmtaylor
Copy link
Contributor Author

ccmtaylor commented Oct 21, 2025 via email •
edited
Loading

@ccmtaylor
Copy link
Contributor Author

ccmtaylor commented Nov 4, 2025

@hickford I'm back again. Are you waiting on an action or input from me?

I took a look at the history of github.com/rsc/qr. It only contains 3 commits; Judging by the sha in the version, debian seems to ship the oldest one. The two commits since only introduced // import comments for go modules compatibility, and a package main binary. AFAICT, there are no compatibility issues vs debian's version of the library.

@hickford
Copy link
Owner

hickford commented Nov 4, 2025 •
edited
Loading

Thanks for investigating. Alright, I'll merge this PR then try building the Debian package before tagging a release.

hickford
hickford approved these changes Nov 4, 2025
View reviewed changes
go.mod

require golang.org/x/oauth2 v0.30.0

require rsc.io/qr v0.2.0
Copy link
Owner

@hickford hickford Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version 2018 https://pkg.go.dev/rsc.io/qr but that's not necessarily a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hickford hickford hickford approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ccmtaylor @hickford