Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure mobile auth notifications permissions are properly triggered when the app starts. #11274

Merged
merged 21 commits into from
Mar 13, 2025

Conversation

burtonator
Copy link
Collaborator

@burtonator burtonator commented Mar 4, 2025

Link to Issue

Closes:

"How We Fixed It"

I broke out the mobile notifications onboarding step and placed it BEFORE the main welcome onboarding but with different triggers based on localStorage.

This way if you logout, then login as a different user, you get prompted for mobile notifications.

Test Plan

  • uninstall the app, reinstall, then login again. It should prompt for mobile permissions to send notifications.
  • you also need to create a NEW user and verify the full onboarding works.

Deployment Plan

Other Considerations

@burtonator burtonator marked this pull request as ready for review March 5, 2025 19:29
@burtonator burtonator changed the title DRAFT (ignore) Burton/mobile onboarding toggle Make sure mobile auth notifications permissions are properly triggered when the app starts. Mar 5, 2025
@dillchen dillchen requested a review from KaleemNeslit March 11, 2025 17:38
@KaleemNeslit
Copy link
Collaborator

@burtonator i am testing the PR . i checked out to your branch and i run the mobile app locally . i signup as new user after the notification screen it move me to homePage direct skip the welcome modal . know i am stuck at this Page
image

@KaleemNeslit
Copy link
Collaborator

@burtonator for old user it's working fine but for new i am facing above issue

@burtonator
Copy link
Collaborator Author

@KaleemNeslit Thanks. I tested both old AND new users but I will try again.

@burtonator burtonator merged commit 3c99707 into master Mar 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants