-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure mobile auth notifications permissions are properly triggered when the app starts. #11274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a fresh install of the mobile app...
@burtonator i am testing the PR . i checked out to your branch and i run the mobile app locally . i signup as new user after the notification screen it move me to homePage direct skip the welcome modal . know i am stuck at this Page |
@burtonator for old user it's working fine but for new i am facing above issue |
masvelio
approved these changes
Mar 12, 2025
Israellund
approved these changes
Mar 12, 2025
@KaleemNeslit Thanks. I tested both old AND new users but I will try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes:
"How We Fixed It"
I broke out the mobile notifications onboarding step and placed it BEFORE the main welcome onboarding but with different triggers based on localStorage.
This way if you logout, then login as a different user, you get prompted for mobile notifications.
Test Plan
Deployment Plan
Other Considerations