-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amino support for CommunityPoolSpendProposal #4811
Conversation
466ade4
to
7b8d31b
Compare
Ledger support is ready here for everything except
See https://github.com/hicommonwealth/commonwealth/actions/runs/5883047794/job/15954867599?pr=4811 In the past I have seen this when amino encoding is incorrect, although it is also a general error that pops up if anything is wrong with the TX. Despite the wording of the error, this is probably not a signature error. In manual testing, the message appears correct, so it will take some more investigation to resolve. I propose that we split off a separate ticket for v1 CommunityPoolSpendProposal ledger support. That will allow the rest of the ledger support to move forward. |
Great update Mark. Please go ahead and add that new ticket, cross-linking to original ticket for this PR (I know this ain't Jira) and let's get this out of draft. |
I need to make some updates to our devnet deployments to make this QA-ready. I have tested other chains, but csdk and csdk-beta are not registering unstaked tokens on Keplr. Whoever QAs it would also need a physical ledger device to test with.
|
1cec0b5
to
f2726f5
Compare
Latest commit fixes devnet issues. The bootstrap code included is already deployed to the sandboxes and the CI images. It fixes the native send functionality for keplr. Which means we can test other ledger devices by sending tokens to them. |
…er CommunitySpend in MsgSubmitProposal - encodeCommunitySpend to utils, devnet tests for communitySpend - DRY up tests and add amino tests for all - null check for mindeposit.denom to fix intermittent bug
fix dasel syntax unstaked tokens visible in keplr fix platform for docker update wiki new image ref for CI tests
0c2c659
to
3fa6469
Compare
Link to Issue
Closes: #4731
Description of Changes
MsgSubmitProposal
withCommunityPoolSpendProposal
in v1 (note that this does support it inv1beta1
)"How We Fixed It"
Added gov/aminomessages.ts to amino registry when creating signingClient
Test Plan
redis-cli
>FLUSHALL
(this will clear devnet sandbox params which change with this PR)Deployment Plan
Other Considerations