Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raymond UI bugs fix #9219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Raymond UI bugs fix #9219

wants to merge 2 commits into from

Conversation

Israellund
Copy link
Collaborator

@Israellund Israellund commented Sep 13, 2024

Link to Issue

Closes: #8727

Description of Changes

  • Made fixes for UI bugs Raymond found

"How We Fixed It"

-added some css and made a new scroll function

Test Plan

Deployment Plan

  1. to replicate 1, in CreateComment.tsx, in const [errorMsg, setErrorMsg] = useState<string | null>(null); make null a string, ‘null’, to force an error message
    -confirm that error message is in line with name, and name is in line with "Comment as"
  2. I followed up with Raymond about this and he was unable to replicate it, as was I, so he struck it from the list.
  3. I am confused by this one. In the texts that I found that were of different sizes, some texts in threads are within a span tag and others are within a p tag, which would make sense as to why they are of different sizes. Can someone confirm that the spans and p's are correct? Or should they be changed? I was looking at this community/thread: http://localhost:8080/dydx/discussion/6907-dip-move-the-borrower-pool-to-truefi
  4. I was unable to recreate this, the scrolling seems fine to me. If anyone else can replicate this please let me know and I will fix.
  5. find a comment that you are able to reply to, click Reply, and confirm that the editor now scrolls into view.

@mzparacha
Copy link
Contributor

Still able to reproduce 4 and 5, it only happens on threads with > 10 comments. Everything else worked for me

Screen.Recording.2024-09-30.at.10.13.30.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Raymond's UI bugs he compiled
2 participants