-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docker deployment #9263
base: master
Are you sure you want to change the base?
Added docker deployment #9263
Conversation
RUN apt-get update && apt-get install -y curl # Needed for heroku | ||
ENV PORT=$PORT | ||
COPY ./scripts/datadog-entrypoint.sh /prod/commonwealth | ||
RUN chmod +x /prod/commonwealth/datadog-entrypoint.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we decide that the max old space script is still needed? If so, perhaps it could be chained here at the RUN
declaration? e.g. ./get-max-old-space-size.sh && ./datadog-entrypoint.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use the get-max-old-space-size because the docker container does not know at image build time how much memory the container has.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not talking about container build time, but rather container runtime, during the RUN
step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, for some reason I thought that was the entrypoint 😅
What I meant was the CMD
step in the other dockerfiles. Nonetheless, LGTM– tweaks can be made later.
# Conflicts: # pnpm-lock.yaml
71a3bf6
to
0d9c31d
Compare
# Conflicts: # libs/shared/package.json # libs/shared/src/canvas/runtime/node.ts # pnpm-lock.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering if anything changes after @timolegros finishes work merging discord bot
Link to Issue
Closes: #9085
Closes: #9158
Description of Changes
Test Plan
Deployment Plan
heroku stack:set container -a commonwealthapp
)production
branch. After this is merged it will be deployed to heroku. This will be our new deployment process.Other considerations
get-max-old-space-size.sh
because the docker image does not have information about the machine it is running on, and as a result it will fail. I suggest we do things the other way, instead of sizing the docker container to fit the dyno, we just use a dyno that will fit the docker container, and scale horizontally