Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom stages should not delete snapshot #9281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

salman-neslit
Copy link

Link to Issue

Closes: #7424

Description of Changes

  • Fixed the issue where adding Custom Stages through the Community Profile was clearing Snapshot spaces when returning to Integrations.
  • Updated the logic to handle empty snapshot inputs while preserving existing Snapshot spaces.

Test Plan

  • Verified the behavior manually by:
  • Adding Snapshot spaces, then adding Custom Stages, and checking the Snapshot spaces remained intact.
  • Testing multiple scenarios (no snapshot, empty snapshot) to ensure proper handling.

Deployment Plan

Other Considerations

@salman-neslit
Copy link
Author

I am not able to assign any one kindly review it. @Israellund @mzparacha @masvelio

@salman-neslit salman-neslit changed the title Issue#7424 adding custom stages should not delete snapshot Adding custom stages should not delete snapshot Sep 19, 2024
@Israellund
Copy link
Collaborator

Israellund commented Sep 23, 2024

@salman-neslit Code looks good, please try to fix failing CI/CD tests and I will approve.
Screenshot 2024-09-23 at 3 22 23 PM

@salman-neslit
Copy link
Author

salman-neslit commented Sep 24, 2024

@Israellund @masvelio
Could you please review this PR when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding custom stages should not delete snapshot spaces
3 participants