Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERC20 Launchpad] - Token Signature Signing step #9320

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Sep 24, 2024

Link to Issue

Closes: #8707

Description of Changes

Added signature signing step for launching a token with some changes to previous steps. Stepwise, it now works like this

  1. First we get a token info draft from the user
  2. This token info is then used to generate token specific community data, and community is created
  3. Then we require the user to sign signatures, and on success, we update the community to utilize this token (and TODO: save this token data in our DB).

"How We Fixed It"

N/A

Test Plan

  1. Enable FLAG_TOKENIZED_COMMUNITY
  2. Visit /createTokenCommunity
  3. Complete the token and community forms (steps 1 and 2) - verify they work
  4. On the signature signing (step 3), verify you are able to launch token without any issues (Note: you won't get a success screen ATM)

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft September 24, 2024 15:34
@mzparacha
Copy link
Contributor Author

Will be keeping this in draft until #9285 is merged, which includes some changes to successfully launch the token.

@mzparacha mzparacha self-assigned this Oct 2, 2024
@mzparacha mzparacha marked this pull request as ready for review October 2, 2024 16:34
Copy link
Contributor

@ianrowan ianrowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from protocol usage perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign to launch token and create community.
2 participants