Add PeerId config to commonwealth, add create-peer-id.js #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
requested changes
Sep 26, 2024
raykyri
added
the
deployment plan
raykyri
changed the title
Rotorsoft
approved these changes
Oct 3, 2024
timolegros
reviewed
Oct 3, 2024
timolegros
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9352
Description of Changes
Replaces START_LIBP2P with PEER_ID inside the Commonwealth server config, and add it as an optional value in the Zod config.
Test Plan
Try starting commonwealth twice with PEER_ID set (use
scripts/create-peer-id.jsto generate a peer ID) and note that libp2p gets started with the same peer ID.Deployment Plan
pnpm create-peer-idlocallyOther Considerations
n/a